sek-consulting / solid-ui

Beautifully designed components. Built with Kobalte & corvu. Styled with Tailwind CSS.
https://www.solid-ui.com
MIT License
832 stars 32 forks source link

fix: cards example now correctly showing border for selected item #71

Closed jcramb closed 6 months ago

jcramb commented 6 months ago

Fixed issue with radio group, in the cards example, not correctly showing border for selected item. The peer-data selector being used was peer-data-[state=checked] which did not work for me in Firefox or Chrome. Following the tailwind documentation I modified it to peer-data-[checked] which fixed the issue!

Original:

Screenshot 2024-03-28 at 23 18 20

Fixed:

Screenshot 2024-03-28 at 23 16 40
changeset-bot[bot] commented 6 months ago

⚠️ No Changeset found

Latest commit: ece66761b36167a4221e4565f7aa71a8b4c5cb74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-ui-components ❌ Failed (Inspect) Mar 29, 2024 6:29am
sek-consulting commented 6 months ago

thanks for the help :) merged!