search

sek-consulting / solid-ui

Beautifully designed components. Built with Kobalte & corvu. Styled with Tailwind CSS.
https://www.solid-ui.com
MIT License
674 stars 25 forks source link

style: Fix missing folding animation for sheet component (#68) #73

Closed declanchiu closed 3 months ago

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: 1a4b01e7de74ccb8f2004ff3f259b345ff68dce0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-ui-components ❌ Failed (Inspect) Mar 30, 2024 8:40am
declanchiu commented 3 months ago

@jcramb I've finished fixing this. #68

declanchiu commented 3 months ago

data-[expand=] equals a null value, which seems very strange, but this is because KOBALT/Dialog's data-expanded and data-closed values are null strings.

image

sek-consulting commented 3 months ago

Thanks for this PR! :) I'll merge it as soon as I fixed all the remaining issues that came up due to moving to the latest solid-start / vinxi versions :)