sek-consulting / solid-ui

Beautifully designed components. Built with Kobalte & corvu. Styled with Tailwind CSS.
https://www.solid-ui.com
MIT License
674 stars 25 forks source link

Improve package manager detection using @antfu/ni #85

Closed wesleycoder closed 2 months ago

wesleycoder commented 2 months ago

Following my comment on #38, I took the liberty of implementing the change from detect-package-manager to @antfu/ni.

This should improve the package manager detection allowing for more flexible use cases like my setup in a monorepo with bun.

Tested it on my repository after a build and it worked without the need for workarounds. My setup is simple and I've not tested other use cases, would appreciate any help if you find it is necessary to test more.

I found the changes to be small and I don't expect much to break, but in any case I'm willing to help solve any side effects.

I've ensured to use pnpm@8 (from brew) so the pnpm-lock.yaml wouldn't change too much, but I suggest upgrading pnpm as pnpm@8 is already marked for deprecation (maybe I'll try another PR for it).

maybe this will resolve #38, but as my approach was focused on another use case I'm submitting the PR without automatic closing for it.

changeset-bot[bot] commented 2 months ago

🦋 Changeset detected

Latest commit: 222be1e6442ac7ef9df487939bcb0b188ce09f38

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----------- | ----- | | solidui-cli | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

vercel[bot] commented 2 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-ui-components ❌ Failed (Inspect) May 2, 2024 5:54pm
sek-consulting commented 2 months ago

Thanks for your work! :) I'll merge it untested since I don't have bun installed and I'm currently on updating every single component to kobalte 0.13. So I'll trust you on this one ^^

wesleycoder commented 2 months ago

I love the generated changeset name lol