search

sek-consulting / solid-ui

Beautifully designed components. Built with Kobalte & corvu. Styled with Tailwind CSS.
https://www.solid-ui.com
MIT License
674 stars 25 forks source link

feat: use new corvu type system and separate packages #90

Closed GiyoMoon closed 1 month ago

GiyoMoon commented 1 month ago

Updates the corvu components to use the new type system and import them from the separated packages.

(I also had to update your tsconfig files to use "moduleResolution": "bundler" instead of node because corvu only builds for esm and node is an outdated cjs resolution strategy. Read more here: https://www.typescriptlang.org/tsconfig/#moduleResolution

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: d638f1bcfccf47937299d35091db0e1c4a437e7b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
solid-ui-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 14, 2024 9:32pm
GiyoMoon commented 1 month ago

@sek-consulting I updated the PR to use generic components :) I'm going to release an update to corvu tomorrow which fixes the current type errors that are present. (See the drawer-demo.tsx file for example) I'll update the PR and set it to ready for review once I'm done!