search

sekaiproject / ponscripter-fork

Fork of the Ponscripter visual novel engine to take advantage of SDL2 and improve Steam integration
GNU General Public License v2.0
74 stars 28 forks source link

Mouse clicks should be less picky #61

Closed euank closed 10 years ago

euank commented 10 years ago

Since fixing #29, mouse clicks require a "down" and "up" event in exactly the same location.

As mentioned in #60, this can make it feel unresponsive at times. I suspect this is also related to #59.

Perhaps there should be an area around each click the mouse can move within, or perhaps the behavior should return to ignoring mouse movement.

Yirba commented 10 years ago

As long as the #29 remains fixed when doing so, I think it would be best to revert behaviour so that the mousedown and mouseup don't need to be in the same location. The game will still likely do as the user intends in the vast majority of cases. So I don't see the need of going to the trouble of making sure the mouseup is within a certain radius of the mousedown.

euank commented 10 years ago

I'm hoping that 6688a796dda29d60220e5a5b5179d8a21aa42d8d will fix this issue.

It now pumps mousedown events on focus gained, maximized, etc. This will hopefully keep everything in #29 fixed. However, I feel like once or twice out of dozens of times when I was fixing it, I had the case of the mousedown event coming after the resize/maximize event (and not being in the queue at the same time). I couldn't get that to happen this time, but if any of you can make the bug manifest still I'd be interested.

I'll comment again once it's live...

euank commented 10 years ago

Should be live. As far as I can tell, everything works as expected. Please reopen this issue if there are any problems related to this.