search

sekaiproject / ponscripter-fork

Fork of the Ponscripter visual novel engine to take advantage of SDL2 and improve Steam integration
GNU General Public License v2.0
74 stars 28 forks source link

csel-list items and text into clipboard fo accessibility needs (rough) #66

Closed ghost closed 10 years ago

ghost commented 10 years ago

The only things by now I've managed to do is to put csel-list items and the text itself into clipboard. P.S. don't know about all those red things in src/PonscripterLabel_command.cpp, maybe it's because i used browser to make changes into code (added only strings 2829-2832).

euank commented 10 years ago

Unfortunately, this has a few issues with it.

First of all, clobbering what's on the clipboard isn't nice. I don't expect a game to alter what's on my clipboard unless I explicitly click a "copy" button or ctrl+c or something. If this were included, it would have to be optional.

Second, I'm not even sure that it works correctly.

For example, when I run your branch on narcissu side 2nd in the prologue, any line it does copy has "\" appended to it. The line "The 7th floor" very early in just copied "@" to the clipboard. The next line (before my eyes) set the clipboard to empty my first time through, but I can't reproduce that.

The biggest blocker here is that this absolutely needs to be optional if it is implemented. It should also work correctly though.

Thanks for the effort though; this would be nice to have if those issues were addressed I think (though I'd like a little discussion / documentation on what accessibility programs work with this and how too).

To be clear, I'm not opposed to adding this feature. I just think that it needs to be optional (perhaps a command line flag) and it also has a few other issues with it. I hope you can keep working on this and get the issues I pointed out above fixed. Thanks!