search

sekaiproject / ponscripter-fork

Fork of the Ponscripter visual novel engine to take advantage of SDL2 and improve Steam integration
GNU General Public License v2.0
74 stars 28 forks source link

"quake" cmds don't quake #87

Closed UncleMion closed 9 years ago

UncleMion commented 9 years ago

The "quake", "quakex", and "quakey" cmds should produce a screen-shaking effect, but don't. I'm guessing it's related to the SDL2 update. I wonder if some of the default numbered effects used in "effect" etc. may be broken as well but haven't tested yet.

UncleMion commented 9 years ago

I'm intending to tackle this issue myself, but if you already have an idea of how to fix it then by all means do so.

DanielOaks commented 9 years ago

Yeah, that effect code was put in before the SDL2 update and hasn't gotten much love since. Most of the SDL2 work was done by @euank, but I'll take a quick look and see if anything jumps out at me.

On 24 September 2015 at 13:11, UncleMion notifications@github.com wrote:

I'm intending to tackle this issue myself, but if you already have an idea of how to fix it then by all means do so.

— Reply to this email directly or view it on GitHub https://github.com/sekaiproject/ponscripter-fork/issues/87#issuecomment-142793082 .

UncleMion commented 9 years ago

It seems like there should be an efficient way to do the quake on the GPU end, considering it keeps the screen image static while performing the effect, just offsets it. But I don't know how GPUs handle that.

UncleMion commented 9 years ago

I've confirmed that numbered effects don't work either. I'll look at the dll-based code, that must have the SDL2 stuff.

DanielOaks commented 9 years ago

Hmm, thanks. I ported them almost directly from Onscripter-EN quite a while ago (and Narcissu doesn't use much/any effects iirc), so it makes sense. I'll take a look tonight when I get home, keep me posted!

On 24 September 2015 at 13:51, UncleMion notifications@github.com wrote:

I've confirmed that numbered effects don't work either. I'll look at the dll-based code, that must have the SDL2 stuff.

— Reply to this email directly or view it on GitHub https://github.com/sekaiproject/ponscripter-fork/issues/87#issuecomment-142801062 .

DanielOaks commented 9 years ago

Offtopic: Might be good to include some/some more example files, ones that just run through the effects to easily test them out, especially since that spot of code isn't tested as much.

On 24 September 2015 at 13:54, Daniel Oaks daniel@danieloaks.net wrote:

Hmm, thanks. I ported them almost directly from Onscripter-EN quite a while ago (and Narcissu doesn't use much/any effects iirc), so it makes sense. I'll take a look tonight when I get home, keep me posted!

On 24 September 2015 at 13:51, UncleMion notifications@github.com wrote:

I've confirmed that numbered effects don't work either. I'll look at the dll-based code, that must have the SDL2 stuff.

— Reply to this email directly or view it on GitHub https://github.com/sekaiproject/ponscripter-fork/issues/87#issuecomment-142801062 .

UncleMion commented 9 years ago

That sounds reasonable. I'll try to get an effect test script together. Say, do you folks need a copy of the *NScr Command Reference? I've got the XML version I made some time back, but the XML/XSLT doesn't seem to behave very well with modern browsers. I should be able to generate an html file at least. May add your steam-related cmds at some point too :)

DanielOaks commented 9 years ago

Awesome, will keep an eye out.

I've tended to use the Reference on your site thus far. Could be useful to throw the source files for it on Github? :)

On 24 September 2015 at 15:08, UncleMion notifications@github.com wrote:

That sounds reasonable. I'll try to get an effect test script together. Say, do you folks need a copy of the *NScr Command Reference? I've got the XML version I made some time back, but the XML/XSLT doesn't seem to behave very well with modern browsers. I should be able to generate an html file at least. May add your steam-related cmds at some point too :)

— Reply to this email directly or view it on GitHub https://github.com/sekaiproject/ponscripter-fork/issues/87#issuecomment-142812794 .

UncleMion commented 9 years ago

Well the fix was simple, just took a while for me to relearn the code well enough to find the problem. (The class and method names in this project can be highly confusing, I know. I'll see what else may have gotten broken unknowingly.) I'll put together that quick effect test script once I relearn enough *nscr scripting for the job.