search

sekassel / stp-24-server-tracker

Issue Tracker and Feature Requests for the STP 2024 Server.
0 stars 0 forks source link

Max members of a game can be larger then the integer limit #9

Closed Baldi-OG closed 3 months ago

Baldi-OG commented 3 months ago

Describe the bug Setting the max members field of a game to a really really large value (>2,147,483,647) instantly disables most game browser implementations, since it's to be expected that most teams implemented max members as an int.

To Reproduce

  1. Post game with 999999999999 max member count
  2. Game browser will die
  3. For some reason patching it to less then max members afterwards does not seem to fix the problem
  4. See error
  5. Only deleting the game will make it game browser function again

Expected behavior Even though it is not explicitly stated in the server documentation, the server should not allow max member counts this high. The post/patch request should not be allowed.

Additional context Maximum possible max members screenshot

This happens when 1 (or 8349834545) too many screenshot

Clashsoft commented 3 months ago

Will be fixed in the next update.