Remove pio_sm_set_jmp_pin because Pico SDK 2 has it

sekigon-gonnoc / Pico-PIO-USB

USB host/device implementation using PIO of raspberry pi pico (RP2040).

MIT License

1.32k stars 137 forks source link

Remove pio_sm_set_jmp_pin because Pico SDK 2 has it #126

Closed tannewt closed 1 month ago

mikepparks commented 1 month ago

@tannewt As an outsider, just my $0.02. Wouldn't it be better to leverage PICO_SDK_VERSION_MAJOR or similar version definitions here instead of removing it outright? That change has a chance to break dependencies elsewhere for projects not yet running on the 2.0 line.

hathach commented 1 month ago

@mikepparks you are right, it will take a while for other to migrate to sdk v2 (especially with rp2040 only example). I pushed update to get it working for both sdk v1.5.1 and 2.0.0 also update ci to build with both sdk version to be safe. Since this is breaking tinyusb ci @sekigon-gonnoc would you please reviewing this when you got time. Thank you.

mikepparks commented 1 month ago

@hathach Yeah, exactly. We're trying to update the CI for GP2040-CE, so this is exactly the same problem we're trying to get resolved while being mindful of our community's forks who may not know to update to 2.0 yet.