Closed cuviper closed 4 years ago
Hmm, CI failed 1.31.1 because of the new dev-dependency
for the benchmarks, where rand
only supports Rust 1.32. Let me know how you'd like to deal with that -- could use an older rand
, or just forgo the benchmarks here.
Thanks for the PR! I think we can bump the minimum supported rustc version to 1.32 or something. (In that case, I'll bump crate ver to 0.4.0)
Hmm, CI failed 1.31.1 because of the new
dev-dependency
for the benchmarks, whererand
only supports Rust 1.32. Let me know how you'd like to deal with that -- could use an olderrand
, or just forgo the benchmarks here.
OK, I've bumped to 1.32 and CI is happy. I'll leave it to you whether it would be beneficial to bump further for other features.
LGTM, Thanks!
This ports the change from rust-lang/rust#75974 --
PeekMut
is now constructed withsift: false
, and it is only settrue
byDerefMut
. The same benchmarks are included this PR, and here are my results on this crate:So
bench_find_smallest_1000
is much improved, whilebench_peek_mut_deref_mut
is much worse, just as they found in the standard library. The latter was justified as being "highly artificial" in https://github.com/rust-lang/rust/pull/75974#pullrequestreview-492011705.