Closed chcg closed 5 years ago
Awesome thanks a lot! I’m currently on holiday so won’t be able to look at this for a couple of weeks though.
On Thu, 28 Jun 2018 at 18:20, chcg notifications@github.com wrote:
- prepared appveyor.yml for vs2017 builds and used VS2015 as default like n++ itself
- corrected build issue with resource.rc due to utf-8 with BOM format
- removed generated aps file
- removed unused goto dialog files
appveyor build see https://ci.appveyor.com/project/chcg/securepad/build/2.2.11 containing also build artifacts, e.g.
https://ci.appveyor.com/project/chcg/securepad/build/2.2.11/job/ev74bboaed1vh9lo/artifacts
You can view, comment on, or merge this pull request online at:
https://github.com/DominicTobias/SecurePad/pull/7 Commit Summary
- prepared appveyor.yml for vs2017 builds and used VS2015 as default
File Changes
- D DockingFeature/GoToLineDlg.cpp https://github.com/DominicTobias/SecurePad/pull/7/files#diff-0 (56)
- D DockingFeature/GoToLineDlg.h https://github.com/DominicTobias/SecurePad/pull/7/files#diff-1 (52)
- D DockingFeature/goLine.rc https://github.com/DominicTobias/SecurePad/pull/7/files#diff-2 (33)
- M NppPluginTemplate.vcxproj https://github.com/DominicTobias/SecurePad/pull/7/files#diff-3 (8)
- D Resources.aps https://github.com/DominicTobias/SecurePad/pull/7/files#diff-4 (0)
- M Resources.rc https://github.com/DominicTobias/SecurePad/pull/7/files#diff-5 (2)
- M appveyor.yml https://github.com/DominicTobias/SecurePad/pull/7/files#diff-6 (27)
Patch Links:
- https://github.com/DominicTobias/SecurePad/pull/7.patch
- https://github.com/DominicTobias/SecurePad/pull/7.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/DominicTobias/SecurePad/pull/7, or mute the thread https://github.com/notifications/unsubscribe-auth/AAuZ-uOTqFbO3GE0W6EBu8QDkPULBkz6ks5uBJ_wgaJpZM4U7CY9 .
Sorry I forgot about this 😳 Do you think this would help #8?
appveyor build see https://ci.appveyor.com/project/chcg/securepad/build/2.2.11 containing also build artifacts, e.g. https://ci.appveyor.com/project/chcg/securepad/build/2.2.11/job/ev74bboaed1vh9lo/artifacts would fix #4
Using the already prepared deployment capability of appveyor ( https://www.appveyor.com/docs/deployment/github/#provider-settings ) would provide fix for #5 See test release in my repo https://github.com/chcg/SecurePad/releases from branch https://github.com/chcg/SecurePad/tree/tag_test_build