search

sekruse / metanome-cli

Run Metanome algorithms from the command line
http://www.metanome.de/
Apache License 2.0
7 stars 6 forks source link

Can't start BINDERDatabase, which doesn't implement RelationalInputParameterAlgorithm and TableInputParameterAlgorithm #21

Closed faisal-ksolves closed 1 year ago

faisal-ksolves commented 1 year ago

Hello developers, I am trying to run BINDERDatabase-1.2-SNAPSHOT.jar on CLI with postgres database. i shoot the following command: java -cp metanome-cli-1.1.0.jar:BINDERDatabase-1.2-SNAPSHOT.jar de.metanome.cli.App -a de.metanome.algorithms.binder.BINDERDatabase --input-key INPUT_DATABASE --db-connection db.pgpass --db-type postgresql --output print

But it does not work showing this message on console Algorithm does not implement a supported input method (relational/tables).

In the db.pgpass file we have hostname:port:database:username:password should i include db schema in it?

i want to run algorithm over two column name schema.table1 and schema.table2 can you please provide me cli command to execute it properly.

Thanks

sekruse commented 1 year ago

The issue appears to be that BINDERDatabase is a DatabaseConnectionParameterAlgorithm, but doesn't implement RelationalInputParameterAlgorithm or TableInputParameterAlgorithm as the Metanome CLI expects.

The Metanome CLI could be changed to accept this setup in the Metanome CLI; or alternatively for BINDERDatabase to implement the TableInputParameterAlgorithm interface.

I'm happy to review a pull request but don't have capacity to make this change myself. As a workaround, you also might get away with just removing these few lines.

BINDERDatabase should work with Metanome web interface, though.

faisal-ksolves commented 1 year ago

thanks @sekruse