search

sektioneins / suhosin7

Suhosin Extension for PHP 7.x
https://www.suhosin.org
Other
120 stars 25 forks source link

make build possible on 7.2 and up... #23

Open mcarbonneaux opened 6 years ago

mcarbonneaux commented 6 years ago

for now suhosin7 not build on php 7.2, this patch make possible to build on 7.2 and up...

mckaygerhard commented 6 years ago

i reviewed and tested, seems build and works with php7.2, travis test said fails two checks:

FAIL session id too long [tests/session/max_id_length_toolong.phpt] FAIL session user handler recursive crash - issue suhosin#60 [tests/session/session_recursive_crash2.phpt]

seems are very important the test failed but in certaint environment does not fail!

mcarbonneaux commented 6 years ago

i've seen this test, i've not investigated why session id has changed in size... possible 7.2 session hash size as differente size for now... when i've some time i while investigade in the code why.

mckaygerhard commented 6 years ago

maybe will be necessary ask to php developers directly