search

sekwah41 / Advanced-Portals

An advanced portals plugin for bukkit
GNU Lesser General Public License v3.0
156 stars 65 forks source link

Rework Riding Entities through Portal #306

Open ZorudaRinku opened 2 years ago

ZorudaRinku commented 2 years ago

Old issue: #135

Start of convo: https://discord.com/channels/168282484037910528/249757652664582161/919122169705938974

Reopening a new issue for the rework of riding entities through portals and coming out the other side with full NBT data. If the same camera smoothness issue comes back with the reintegration of this feature it might be worth considering just placing the player and the entity next to each other on the other side. Allowing the player to transfer the entity but with small negligible fact that they'll have to remount on the other side.

sekwah41 commented 2 years ago

Both this task and #305 may be solved with the same main code, however, this will mostly focus on cross-world teleportation while the other task will focus on per world short and long-range teleportation.

We will also want to check that the entities are possibly not controlled by another plugin, because if we kill and re-create them they may end up with broken logic. E.g. on servers like Hypixel where you can have temporary rideable pets, it may be abusable to create an animal spawner.

NamiUni commented 2 years ago

Can this feature be made to work cross server? I have a lot of users on my server who want to move their horses to another server. If it were possible that would be so great!

sekwah41 commented 2 years ago

Sadly that's quite a lot different, as we would have to serialise the entities and do quite a lot more. Though I can take a look into it.

NamiUni commented 2 years ago

Oh, that's true. I hope I can contribute to this feature when I have time. Thank you for answering my ramblings!