search

sekwah41 / Advanced-Portals

An advanced portals plugin for bukkit
GNU Lesser General Public License v3.0
158 stars 65 forks source link

[suggestion] folia support #375

Closed cgw2023 closed 1 year ago

cgw2023 commented 1 year ago

Please make Advanced Portals support folia platform 1.20.1 It is the newest papermc offical fork https://github.com/PaperMC/Folia It is getting popular nowadays Thank you so much!

sekwah41 commented 1 year ago

Wont be a high priority but I can explore it with the recode. Though my priority is getting the base features through first.

Is it not working with Folia or is it more optimising it for better performance?

cgw2023 commented 1 year ago

Wont be a high priority but I can explore it with the recode. Though my priority is getting the base features through first.

Is it not working with Folia or is it more optimising it for better performance?

Plugin cannot be enabled in folia platform Folia is different from spigot/paper, it have alot of changes for multithreading, it is made by papermc team.

https://github.com/PaperMC/Folia

Folia is getting popular now

image

sekwah41 commented 1 year ago

Can you please try using the latest version of advanced portals? by the looks of it you are using a very old version.

0.9.+ would give me more feedback :)

cgw2023 commented 1 year ago

Can you please try using the latest version of advanced portals? by the looks of it you are using a very old version.

0.9.+ would give me more feedback :)

oh sorry i pressed the wrong version on modrinth

this is version 0.9.2 with error

image

logs: https://mclo.gs/wf14aD4

Please help

sekwah41 commented 1 year ago

Ive had to prioritise other projects rn but im part way through a re-code of advanced portals, I can take a look to see why these dont work during that. Though if I get some time on the weekend I can try to pull it down and gauge how much work it would be to add this.

sekwah41 commented 1 year ago

Also given the error, there is a risk that it is Folia that is actually erroring, otherwise, the advanced portals Listeners class would be at the top of the stack trace.

Though it could be because I trigger it too early depending on whats going on, so ill have to experiment and see if its just a weird quirk of how Folia works, if it's broken on their end or if its something I can fix.

sekwah41 commented 1 year ago

I've added Folia support, at least a rough draft. Currently, Folia doesn't seem to properly Implement some of the nether portal events so avoid making nether portal portals until they have done that (even if you are on portal cooldown it'll still trigger as it doesn't fire at all).

It may require more events though folia should really make it support the current ones properly.

sekwah41 commented 1 year ago

Will be in next release likely tomorrow.

sekwah41 commented 1 year ago

Check out this if you want Advanced Portals Folia.zip

sekwah41 commented 1 year ago

I may re-consider adding Folia support as it forces such a new Java requirement blocking off any earlier paper versions than 1.17. However, most of the userbase is on 1.16+ at least.

sekwah41 commented 1 year ago

Though with the recode I am mostly planning to support the latest versions with priority so that is fine likely going forward.