search

sekwah41 / Advanced-Portals

An advanced portals plugin for bukkit
GNU Lesser General Public License v3.0
154 stars 65 forks source link

High Velocity Portal Entry - Commands don't issue #389

Open TreemanKing opened 11 months ago

TreemanKing commented 11 months ago

Entering a portal at a high velocity will cause the player to first be teleported to the portal destination (end /nether), corrects itself. However, it does not issue any commands.

This can be seen by the following clip (last 10 seconds)

https://medal.tv/games/minecraft/clips/1vhfO1Wsaf0UOB/DvP9B1mzf1vo?invite=cr-MSxVUkosMjAwNDEzODc1LA

I haven't looked into any of the code yet but I'll have a look tomorrow.

sekwah41 commented 11 months ago

Hm ive not seen that one before, usually, they trigger. I don't have time right now but I will take a look when I can too.

TreemanKing commented 11 months ago

Hm ive not seen that one before, usually, they trigger. I don't have time right now but I will take a look when I can too.

Just had a small look, doesn't look the there's a listener utilising the EntityEnterPortalEvent. Probably would be better to utilise this rather than EntityPortalEvent as it acts earlier.

sekwah41 commented 11 months ago

There have been some changes between the events across versions as well as Paper has some extra changes, ill have to check and see which ones exist across versions supported.

TreemanKing commented 11 months ago

There have been some changes between the events across versions as well as Paper has some extra changes, ill have to check and see which ones exist across versions supported.

Seems like it's supported back from 1.13 (EntityPortalEnterEvent)