search

sekwah41 / Re-Skin

Skin customiser for mc
MIT License
7 stars 6 forks source link

Url whitelist blocking /setskin reset command #32

Closed Kariaro closed 3 years ago

Kariaro commented 3 years ago

https://github.com/sekwah41/Re-Skin/blob/770c2c04d8af2fad4125a82d711bc85b9c1d2ae0/src/main/java/com/sekwah/reskin/client/ClientSkinManager.java#L49

If this was an intended functionallity I would class this as a bug introduced by the url checking algorithm.

This error is generated not from the execute method but from the URLArgument type class.

sekwah41 commented 3 years ago

See the following code

https://github.com/sekwah41/Re-Skin/blob/770c2c04d8af2fad4125a82d711bc85b9c1d2ae0/src/main/java/com/sekwah/reskin/commands/ClearSkinCommand.java#L48

That is why this exists.

sekwah41 commented 3 years ago

It's for internally tracking when it should be set back as it's not possible as a normal set string.

Kariaro commented 3 years ago

https://github.com/sekwah41/Re-Skin/blob/770c2c04d8af2fad4125a82d711bc85b9c1d2ae0/src/main/java/com/sekwah/reskin/commands/SetSkinCommand.java#L53

Why is the setskin command skipping the whitelist check if the input url is reset then?

sekwah41 commented 3 years ago

Because an old feature that was an alternative that I just hadn't fully removed. I should remove that code.