search

sekwah41 / mobalytics-repackager

Mobalytics tool for linux
11 stars 3 forks source link

AUR package #36

Open fabifont opened 1 year ago

fabifont commented 1 year ago

It would be great if you build an AUR package for Arch Linux and Arch-based distros. You can find the PKGBUILD here

I've seen that you are integrating the work done by @emaxoda but a PR has yet to be merged. After that you can submit the request to the AUR.

Let me know if I there is anything I can do to help you

sekwah41 commented 1 year ago

The pr has a lot of different changes that I cannot merge directly on.

I personally have never created a AUR package before or messaged with PKGBUILD stuff too much.

sekwah41 commented 1 year ago

For the AUR we may also want to make sure we follow these guidelines https://wiki.archlinux.org/title/Electron_package_guidelines which I think that the package @emaxoda may have already done.

sekwah41 commented 1 year ago

I think the non-packaged approach may be nice, use the patcher then rip the files it needs to run.

I do have other projects I need to work on though. I will see if I get some time :)

Though I think compiling it may also reduce clutter and size from stuff like node-modules.

emaxoda commented 1 year ago

If the main repo were to distribute a non packaged zip/tar it would be easier for the end users saving time and downloading of dependencies on then, (npm and packager dependencies), it would be more of a "package"-bin, the architecture is already specified on the PKGBUILD. On the same hand aur users are used to downloading dependencies to build packages. My main concern was the license. Since it's a privative app repackaged, the repackager uses MIT because it just a mean to an end, it just patches and repackages the app and resulting on an app called mobalytics-desktop. And idk, I got "stuck" there, I didn't know if I should consult with the moba guys to see if they were okay with it. That was why I didn't upload it to the AUR.

sekwah41 commented 1 year ago

Yea, I think making something publically available on GitHub will be fine but I am unsure about the AUR at least from a pre-built perspective.

I believe the AUR should be fine with a compile it on your machine version as we are not distributing the code. It's how a lot of other AUR tools get away with it all. (i think?)

sekwah41 commented 1 year ago

I think what ill do is create a PKG file for the sake of me learning how to do it that pulls down the latest, though of anyone can advise me on the rules with licensing on AUR I will happily submit that :)

emaxoda commented 1 year ago

The PKGBUILD I made compiles the app by downloading a tag, it makes the repackager make a dir only release and use then installs the files to /opt So I think so far seems complaint with the AUR rules

sekwah41 commented 1 year ago

Ive just made some changes to provide a pre-built lock file to help speed up the dependency resolving section of the builds. So im gonna leave it for now with this https://github.com/sekwah41/mobalytics-archlinux (i nabbed your desktop file & icon copying :P) being the always latest git build version. There is a branch that also allows you to to use the native electron that is installed to reduce the install size, though i need to disable debug mode on the un-packaged version.

I mostly just wanted to get some hands on experience with how to create pkgbuild files.