Closed tigercosmos closed 2 weeks ago
I noticed that the upstream code and our code are not consistent. Perhaps we need to update?
@gyl30 LightPcapNg in our repo is a forked version with some customized implementation. I did an upgrade in this PR: https://github.com/seladb/PcapPlusPlus/pull/1336 recently. Seems I didn't do it perfectly (the warning parts).
When I added LightPcapNg I didn't want to add it as a git submodule because submodules require the user to specifically fetch them (a simple git clone
won't fetch them by default).
My original plan was to update the code once in a while - both fetch from upstream, as well as contribute the changes we make to the original repo. Unfortunately I didn't follow that plan...
Maybe it's time to actually do it? Meaning, contribute the patches we have to the original repo, and then update the code to the latest?
Agreed, let's sync the updates upstream so that others can benefit from our updates as well.
Maybe it isn't worth it. The original LightPcapNg has been out of maintenance for a long time (many years with a few commits). In addition, it will take a lot of effort to sync our code back to the original LightPcapNg. I think the proper way is to create a forked repo under PcapPlusPlus (organization) , and move the current code to that forked repo. Later, it will be easier to use git to sync from upstream if upstream has new updates.
Using a fork and contributing updates back to the upstream, if the upstream cannot accept our updates in a timely manner, we maintain the fork. Would this be better?
yes, sounds good
I forked it here: https://github.com/PcapPlusPlus/LightPcapNg
I think we can now update our patches to this fork and try to push the to upstream
@seladb I think it's better to open another issue to migrate the code here to the forked repo, so just opened #1348.
This issue should be only for fixing the warning.
as the action started to fail due to the warning, this issue should be resolved ASAP. per https://github.com/seladb/PcapPlusPlus/actions/runs/9047392074
build log