search

seladb / PcapPlusPlus

PcapPlusPlus is a multiplatform C++ library for capturing, parsing and crafting of network packets. It is designed to be efficient, powerful and easy to use. It provides C++ wrappers for the most popular packet processing engines such as libpcap, Npcap, WinPcap, DPDK, AF_XDP and PF_RING.
https://pcapplusplus.github.io/
The Unlicense
2.68k stars 650 forks source link

Removed dead code from PcapRemoteDevice. #1538

Closed Dimi1010 closed 1 month ago

Dimi1010 commented 1 month ago

ThreadStart, remoteDeviceCaptureThreadMain and getCaptureThreadStart are artifacts left over from previous refactor.

PcapLiveDevice currently handles all capture through pcap_dispatch in PcapLiveDevice::captureThreadMain.

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.91%. Comparing base (b27e84f) to head (c1d0af8). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1538 +/- ## ========================================== + Coverage 82.87% 82.91% +0.03% ========================================== Files 273 273 Lines 46296 46272 -24 Branches 9294 9287 -7 ========================================== - Hits 38369 38366 -3 + Misses 7088 7083 -5 + Partials 839 823 -16 ``` | [Flag](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [fedora39](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.56% <ø> (ø)` | | | [macos-12](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `80.88% <ø> (-0.01%)` | :arrow_down: | | [macos-13](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `80.30% <ø> (ø)` | | | [macos-14](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `80.23% <ø> (ø)` | | | [mingw32](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `71.43% <ø> (+0.03%)` | :arrow_up: | | [mingw64](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `71.43% <ø> (+0.03%)` | :arrow_up: | | [npcap](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `84.86% <ø> (+0.05%)` | :arrow_up: | | [rhel94](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.31% <ø> (-0.03%)` | :arrow_down: | | [ubuntu2004](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `57.88% <ø> (-0.03%)` | :arrow_down: | | [ubuntu2004-zstd](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `58.01% <ø> (-0.02%)` | :arrow_down: | | [ubuntu2204](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.27% <ø> (-0.01%)` | :arrow_down: | | [ubuntu2204-icpx](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `58.43% <ø> (+0.03%)` | :arrow_up: | | [unittest](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `82.91% <ø> (+0.03%)` | :arrow_up: | | [windows-2019](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `84.90% <ø> (+0.07%)` | :arrow_up: | | [windows-2022](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `84.91% <ø> (+0.08%)` | :arrow_up: | | [winpcap](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `84.88% <ø> (+0.08%)` | :arrow_up: | | [xdp](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1538/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `49.27% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.