search

seladb / PcapPlusPlus

PcapPlusPlus is a multiplatform C++ library for capturing, parsing and crafting of network packets. It is designed to be efficient, powerful and easy to use. It provides C++ wrappers for the most popular packet processing engines such as libpcap, Npcap, WinPcap, DPDK, AF_XDP and PF_RING.
https://pcapplusplus.github.io/
The Unlicense
2.68k stars 650 forks source link

Refactor DHCP port checking code in DhcpLayer #1546

Closed nadongjun closed 4 weeks ago

nadongjun commented 4 weeks ago

Description

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.93%. Comparing base (91cde5e) to head (f5a1e2d). Report is 1 commits behind head on dev.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1546 +/- ## ========================================== - Coverage 82.94% 82.93% -0.01% ========================================== Files 273 273 Lines 46343 46348 +5 Branches 9310 9281 -29 ========================================== + Hits 38439 38441 +2 - Misses 7051 7098 +47 + Partials 853 809 -44 ``` | [Flag](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [fedora39](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.54% <100.00%> (-0.03%)` | :arrow_down: | | [macos-12](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `80.90% <100.00%> (+<0.01%)` | :arrow_up: | | [macos-13](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `80.32% <100.00%> (-0.01%)` | :arrow_down: | | [macos-14](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `80.24% <100.00%> (+<0.01%)` | :arrow_up: | | [mingw32](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `71.44% <100.00%> (-0.03%)` | :arrow_down: | | [mingw64](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `71.43% <100.00%> (-0.03%)` | :arrow_down: | | [npcap](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `84.82% <100.00%> (-0.09%)` | :arrow_down: | | [rhel94](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.31% <100.00%> (-0.01%)` | :arrow_down: | | [ubuntu2004](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `57.91% <100.00%> (+<0.01%)` | :arrow_up: | | [ubuntu2004-zstd](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `58.04% <100.00%> (+<0.01%)` | :arrow_up: | | [ubuntu2204](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.27% <100.00%> (-0.01%)` | :arrow_down: | | [ubuntu2204-icpx](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `58.48% <100.00%> (+0.03%)` | :arrow_up: | | [ubuntu2404](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.51% <100.00%> (-0.01%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `82.93% <100.00%> (-0.01%)` | :arrow_down: | | [windows-2019](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `84.93% <100.00%> (-0.01%)` | :arrow_down: | | [windows-2022](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `84.94% <100.00%> (-0.01%)` | :arrow_down: | | [winpcap](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `84.91% <100.00%> (-0.01%)` | :arrow_down: | | [xdp](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1546/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `49.30% <100.00%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

seladb commented 4 weeks ago

Thank you @nadongjun for your contribution to this project, much appreciated! 🙏 ❤️