seladb / PcapPlusPlus

PcapPlusPlus is a multiplatform C++ library for capturing, parsing and crafting of network packets. It is designed to be efficient, powerful and easy to use. It provides C++ wrappers for the most popular packet processing engines such as libpcap, Npcap, WinPcap, DPDK, AF_XDP and PF_RING.
https://pcapplusplus.github.io/
The Unlicense
2.74k stars 672 forks source link

Updated Packet++ headers to use `override` and Cpp type casts. #1563

Closed Dimi1010 closed 1 month ago

Dimi1010 commented 2 months ago
codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 92.85714% with 24 lines in your changes missing coverage. Please review.

Project coverage is 82.88%. Comparing base (0aa0c83) to head (3472012). Report is 3 commits behind head on dev.

Files with missing lines Patch % Lines
Packet++/header/SSLLayer.h 55.55% 4 Missing :warning:
Packet++/header/SSLHandshake.h 84.21% 3 Missing :warning:
Packet++/header/IPSecLayer.h 75.00% 2 Missing :warning:
Packet++/header/LLCLayer.h 50.00% 2 Missing :warning:
Packet++/header/StpLayer.h 86.66% 2 Missing :warning:
Packet++/header/TelnetLayer.h 50.00% 2 Missing :warning:
Packet++/header/WakeOnLanLayer.h 60.00% 2 Missing :warning:
Packet++/header/FtpLayer.h 75.00% 1 Missing :warning:
Packet++/header/GreLayer.h 90.90% 1 Missing :warning:
Packet++/header/NdpLayer.h 92.30% 1 Missing :warning:
... and 4 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #1563 +/- ## ========================================== - Coverage 82.90% 82.88% -0.03% ========================================== Files 273 273 Lines 46261 46206 -55 Branches 9299 9454 +155 ========================================== - Hits 38354 38297 -57 - Misses 7053 7306 +253 + Partials 854 603 -251 ``` | [Flag](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [fedora39](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.48% <85.44%> (+<0.01%)` | :arrow_up: | | [macos-12](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `80.86% <92.85%> (-0.03%)` | :arrow_down: | | [macos-13](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `80.27% <92.85%> (-0.03%)` | :arrow_down: | | [macos-14](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `80.20% <92.85%> (-0.03%)` | :arrow_down: | | [mingw32](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `70.22% <72.58%> (-0.09%)` | :arrow_down: | | [mingw64](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `70.17% <72.58%> (-0.10%)` | :arrow_down: | | [npcap](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `84.81% <96.95%> (-0.03%)` | :arrow_down: | | [rhel94](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.23% <85.13%> (-0.03%)` | :arrow_down: | | [ubuntu2004](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `57.78% <83.69%> (-0.07%)` | :arrow_down: | | [ubuntu2004-zstd](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `57.90% <83.69%> (-0.07%)` | :arrow_down: | | [ubuntu2204](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.16% <85.13%> (-0.06%)` | :arrow_down: | | [ubuntu2204-icpx](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `58.37% <88.69%> (-0.02%)` | :arrow_down: | | [ubuntu2404](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `74.46% <86.06%> (-0.02%)` | :arrow_down: | | [unittest](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `82.88% <92.85%> (-0.03%)` | :arrow_down: | | [windows-2019](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `84.86% <96.95%> (-0.03%)` | :arrow_down: | | [windows-2022](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `84.85% <96.95%> (-0.04%)` | :arrow_down: | | [winpcap](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `84.83% <96.95%> (-0.02%)` | :arrow_down: | | [xdp](https://app.codecov.io/gh/seladb/PcapPlusPlus/pull/1563/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | `49.13% <83.28%> (-0.08%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

clementperon commented 2 months ago

LGTM but didn't check all the files, @Dimi1010 did you use CPPcheck to do this ?

Dimi1010 commented 2 months ago

LGTM but didn't check all the files, @Dimi1010 did you use CPPcheck to do this ?

Yes, when I remembered about it. Started by searching for them manually initially.