Check for called function exports

selaux / eslint-plugin-filenames

Eslint plugin to check filenames.

318 stars 35 forks source link

Check for called function exports #29

Closed shashank-saxena closed 6 years ago

shashank-saxena commented 6 years ago

Allows called function(CallExpression) exports to be checked.

function abc() {}

module.exports = abc();

selaux commented 6 years ago

Sounds good to me. Can you have a look at the tests?

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling e645508ab439d65ef509b3d3881f39f1bc6681ca on shashank-saxena:master into bb49b4a82010818b4d00004e2ab6589aa247ac23 on selaux:master.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling e645508ab439d65ef509b3d3881f39f1bc6681ca on shashank-saxena:master into bb49b4a82010818b4d00004e2ab6589aa247ac23 on selaux:master.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling f54fab9442841d97206fe93517a71ba7f453cc79 on shashank-saxena:master into bb49b4a82010818b4d00004e2ab6589aa247ac23 on selaux:master.

coveralls commented 6 years ago

Coverage remained the same at 100.0% when pulling e645508ab439d65ef509b3d3881f39f1bc6681ca on shashank-saxena:master into bb49b4a82010818b4d00004e2ab6589aa247ac23 on selaux:master.

shashank-saxena commented 6 years ago

@selaux

Added test cases.

selaux commented 6 years ago

LGTM. Thx for the PR.

selaux commented 6 years ago

@shashank-saxena I hid the thing behind an option with 1.3.1 as it was causing errors on existing installs.

shashank-saxena commented 6 years ago

@selaux

OK. So do you want me to disable that check for default exports or it is ok to have that with an option.

selaux commented 6 years ago

For now it is ok. I'm not sure how to proceed in the future yet...