selaux / eslint-plugin-filenames

Eslint plugin to check filenames.
323 stars 36 forks source link

bug[match-regex]: negative lookahead doesn't work #39

Open Hotell opened 5 years ago

Hotell commented 5 years ago

I wanna trigger lint error when barrel ( index ) file has .tsx extension.

Also this rule should check that files use kebab case only.

Why? tsx == component inside and barrel files are supposed to export only public api

my regex rule:

const eslintConfig = {
  rules: {
    'filenames/match-regex': ['error', '^((?!(index.tsx))[a-z][a-z-.]*[a-z])$'],
  },
};

index.tsx -> NO ERORR (WRONG ❌ ) foo-bar.tsx -> NO ERROR (✅) FooBar.tsx -> ERROR (kebab case only) (✅)

regex is valid: https://regexr.com/

image image

Hotell commented 5 years ago

So I dig into the source a bit, and the problem is not within lookahead. the issue is that the lint rule is matching only against filename, whilst ignoring the extension.

👉 https://github.com/selaux/eslint-plugin-filenames/blob/master/lib/rules/match-regex.js#L29

when changed to

matchesRegex = conventionRegexp.test(`${parsed.name}${parsed.ext}`)

everything is validate correctly.

Now question is how to proceed with this. I see two options:

  1. use name + extension to match regex ( which might introduce breaking changes -> bump major version )
    1. provide additional flag that extensions should be taken into account

WDYT? I'll submit PR after we get to an agreement.

Cheers

dolsem commented 4 years ago

I created my own plugin for the same purpose, it validates against the full name instead.

Igorkowalski94 commented 3 months ago

As an alternative, you can use eslint-plugin-project-structure

Cloud Shows an illustrated sun in light mode and a moon with stars in dark mode. Cloud

FolderOwl
eslint‑plugin-project‑structure

ESLint plugin with rules to help you achieve a scalable, consistent, and well-structured project.

Create your own framework! Define your folder structure, advanced naming conventions, file composition, and create independent modules.

Take your project to the next level and save time by automating the review of key principles of a healthy project!

[![npm](https://img.shields.io/npm/v/eslint-plugin-project-structure.svg?&logo=nodedotjs&color=%231f6feb&labelColor=%23212830)](https://www.npmjs.com/package/eslint-plugin-project-structure#root)[![npm downloads](https://img.shields.io/npm/dy/eslint-plugin-project-structure.svg?&logo=nodedotjs&label=Downloads&color=%238957e5&labelColor=%23212830)](https://www.npmjs.com/package/eslint-plugin-project-structure#root)[![Check, test, build](https://img.shields.io/github/actions/workflow/status/Igorkowalski94/eslint-plugin-project-structure/check.yml?&logo=github&color=%23238636&label=Check%2C%20test%2C%20build&labelColor=%23212830)](https://github.com/Igorkowalski94/eslint-plugin-project-structure/actions/workflows/check.yml)[![Sponsor](https://img.shields.io/badge/Sponsor-grey?logo=githubsponsors&style=flat&color=%23212830)](https://github.com/sponsors/Igorkowalski94)[![GitHub Repo stars](https://img.shields.io/github/stars/igorkowalski94/eslint-plugin-project-structure?label=Star)](https://github.com/Igorkowalski94/eslint-plugin-project-structure)

project‑structure/​folder‑structure

Enforce rules on folder structure to keep your project consistent, orderly and well thought out.

Rocket Features:

- Validation of folder structure. Any files/folders outside the structure will be considered an error. - File/Folder name regex validation with features like wildcard `*` and treating `.` as a character, along with other conveniences. - Build in case validation. - Inheriting the folder's name. The file/folder inherits the name of the folder in which it is located. Option of adding your own prefixes/suffixes or changing the case. - Enforcing the existence of a files/folders when a specific file/folder exists. For example, if `./src/Component.tsx` exists, then `./src/Component.test.tsx` and `./src/stories/Component.stories.tsx` must also exist. - Reusable rules for folder structures. - An option to create a separate configuration file with TypeScript support. - Forcing a nested/flat structure for a given folder. - Support for all file extensions. - Folder recursion. You can repeatedly nest a folder structure and set a limit on the nesting depth. There is also an option to change the rule at the final level, such as flattening the folder structure. - Fewer repetitions and precise error messages, even for deeply nested folders (recursion), by representing the folder structure as a tree. - Checking the length of paths and notifying when the limit is exceeded.

project‑structure/​independent‑modules

A key principle of a healthy project is to prevent the creation of a massive dependency tree, where removing or editing one feature triggers a chain reaction that impacts the entire project.

Create independent modules to keep your project scalable and easy to maintain. Get rid of dependencies between modules and create truly independent functionalities.

Rocket Features:

- Creating independent modules in which you control what can be imported (e.g. types, functions, components of one functionality cannot be imported into another functionality). - The ability to create very detailed rules, even for nested folder structures. Whether it's a large module, a sub-module, or a single file, there are no limitations. - Disabling external imports (node_modules) for a given module (Option to add exceptions). - Non-relative/relative imports support. - Support for imports without extension. - Reusable import patterns. - Support for path aliases. The plugin will automatically detect your tsconfig.json and use your settings. There is also an option to enter them manually. - An option to create a separate configuration file with TypeScript support.

project‑structure/​file‑composition

Enforce advanced naming rules and prohibit the use of given selectors in a given file.

Have full control over what your file can contain and the naming conventions it must follow.

Rocket Features:

- File composition validation. - Supported selectors: `class`, `function`, `arrowFunction`, `type`, `interface`, `enum`, `variable`, `variableCallExpression`, `variableTaggedTemplateExpression`. - Rules for exported selectors, selectors in the root of the file and nested/all selectors in the file. They can be used together in combination. - Prohibit the use of given selectors in a given file. For example, `**/*.consts.ts` files can only contain variables, `**/*.types.ts` files can only contain enums, interfaces and types. - Enforcing a maximum of one main function/class per file. - Inheriting the filename as the selector name. Option to add your own prefixes/suffixes, change the case, or remove parts of the filename. - Selector name regex validation. - Build in case validation. - Different rules for different files. - An option to create a separate configuration file with TypeScript support.