added binpacking functionality

selaux / node-sprite-generator

Generates image sprites and their spritesheets (css, stylus, sass or less) from sets of images. Supports retina sprites. Provides express middleware and grunt task.

MIT License

191 stars 39 forks source link

added binpacking functionality #15

Closed schinken closed 9 years ago

schinken commented 10 years ago

Added new functionality using the binpacking npm library.

Example Sprite: example_sprite containing different famfamfam icons and pyconic-free

this method reduces the wasted "white space" to a minimum

ps: package.json is generated from npm by using npm install --save binpacking

selaux commented 10 years ago

Nice work :thumbsup:, a few things before I merge this though:

Can you add a test to check wether the binpacking library is called correctly (For tests that check wether external libraries are called correctly see the compositor unit tests
Can you revert the indentation changes in the package.json? I'd like to have the indentation the same over the whole project.
For the third thing check the inline comment

After that this looks good and is a nice addition to the library :beers:.

schinken commented 10 years ago

working on your list ;)

while writing the tests, i found some bugs in the binpacking library. looking for alternatives (or implement it myself ;))