search

selbekk / app-favicon

An Enonic XP app for adding favicons to your site
Other
3 stars 6 forks source link

Absolute paths #4

Open ComLock opened 8 years ago

ComLock commented 8 years ago

It would be nice to have the option of getting absolute rather than relative paths when using the favicon app. For instance when a site is providing a decorator with menus, footers etc to be used on another domain...

selbekk commented 8 years ago

Hi @ComLock!

Sorry for the late reply - for some reason I haven't seen these issues before now.

Sounds like a good idea, I'll look into this sometime this week if it's still a usecase.

Bellfalasch commented 7 years ago

As I see it, there are no drawbacks of using absolute paths as default, right?

theberzer commented 4 years ago

Actually, for me the application was unusable. We use a reverse proxy from domain.no:80/443 to loclhost:8080. When returning absolute URL's, the favicon wil not work as the url it implements in the HTML is http://localhost:8080/.....

selbekk commented 4 years ago

I'm sorry to hear that @theberzer . Feel free to submit a pull request, and I'll look at it right away.