seldon-code / seldon

A code for opinion dynamics simulations.
GNU General Public License v3.0
6 stars 2 forks source link

Test for activity driven meanfield #52

Open User-DK opened 2 months ago

User-DK commented 2 months ago

As can be seen in this test its for 10 agents from the name of test and the file name as well but the number of agents in this is 50 is this correct. Its little bit concerning!!

https://github.com/seldon-code/seldon/blob/3ba2520cc30e552b8b261a1103a0978a24588d0c/test/test_activity.cpp#L144

https://github.com/seldon-code/seldon/blob/3ba2520cc30e552b8b261a1103a0978a24588d0c/test/res/10_agents_meanfield_activity.toml#L26

MSallermann commented 2 months ago

Whoops, thanks for spotting that! It looks like the filename and the actual test are somewhat out of sync. That particular test case, luckily, does not rely on a particular number of agents, as it just determines the critical controversialness, which is a "property" that is exhibited by the entire ensemble of agents. I suppose a certain minimum number of agents is required to find the critical behavior somewhat reliably. Beyond that, choosing the number agents in this test case is just a question of how fast we want our tests to run :)