Don't set font-family - Githubissues

select2 / select2-bootstrap-theme

A Select2 v4 Theme for Bootstrap 3

https://select2.github.io/select2-bootstrap-theme/

MIT License

872 stars 499 forks source link

Don't set font-family #50

Closed amastaneh closed 8 years ago

amastaneh commented 8 years ago

I think it's not recommended and it's not required that change font-family of select item because

select2.css has not change any font-family
Make conflict with default font of project
Consume time and bandwidth a little

kevin-brown commented 8 years ago

The font-family which appears to be used is the same as the default $font-family value set by Bootstrap, which you should be able to override in the LESS or SASS files.

Consume time and bandwidth a little

Time? Sure, changing the line where it sets the font-family. Bandwidth?

fk commented 8 years ago

@kevin-brown I might not see the forest for the trees right now, but I think @amastaneh is right – select2-bootstrap-theme should just inherit font-family instead of defining its own, just like the Select2 default themes do (most probably for the exact same reasons mentioned).

kevin-brown commented 8 years ago

You're right, one thing I forgot about this is that most people using Bootstrap are using the compiled files and not the source files - so the Bootstrap variable we use for the font family is never actually being changed. Considering that, it makes sense to not override the font family on our side.

fk commented 8 years ago

@kevin-brown 👍 - will be taken care of in the next release.

fk commented 8 years ago

Fixed in 0.1.0-beta.9.