Bootstrap 4 theme - Githubissues

select2 / select2-bootstrap-theme

A Select2 v4 Theme for Bootstrap 3

https://select2.github.io/select2-bootstrap-theme/

MIT License

871 stars 498 forks source link

Bootstrap 4 theme #72

Open angel-vladov opened 6 years ago

angel-vladov commented 6 years ago

This PR includes all the suggestions from Issue #60 and examples updates.

package.json dependencies are updated
All examples in docs folder are updated to use Bootstrap 4
Glyphicons are gone from BS4. Docs now use Fontawesome
Hardcoded variables that were missing in BS 3 are now present in BS 4, so those are replaced as well
Added the new validation classes. I've preserved the old BS 3 validation classes names as well. I find them more useful in some cases, but it might be just me.
All comments in the theme now point to the Bootstrap 4 instead of 3
IE 10, IE 9 and IE 8 are dropped from the README compatibility section. Bootstrap 4 doesn't support them. Bootstrap 4 does support IE 10 with issues. I haven't tested the theme in it.

You can check the example page here.

angel-vladov commented 5 years ago

@ioxFR Depends on the repo owners. Whenever they have free time to do it.

@florianajir The PR is pretty much ready. Besides build tests and adding more notes in the examples everything else is done.

markoj3s commented 5 years ago

@angel-vladov Thank you for your work! I tried it and sounds all good! Only the support for :valid and :invalid styles doesn't seem to be implemented (maybe on purpose?) cf: https://getbootstrap.com/docs/4.2/components/forms/#custom-styles With that also included it would be perfect :)

angel-vladov commented 5 years ago

@markoj3s Thanks for you feedback. Sorry for the delayed response. I'll see how I can introduce those.

florianajir commented 5 years ago

Can we merge it ?

aparakian commented 4 years ago

Do you think this could be merged? Are the owners aware of this?

dereuromark commented 4 years ago

I am also curious about the status for BS4.

florianlacreuse commented 3 years ago

The last release was made 3+ years ago, this PR is 3 years-old, I consider this project dead. In addition, Bootstrap 5 will be released soon (currently in beta).

In our team we use the fork made by @angel-vladov (PR's author): https://github.com/angel-vladov/select2-theme-bootstrap4 He will also make a new theme for Bootstrap 5.

angel-vladov commented 2 years ago

I've created a Bootstrap 5 version

You can find the select2 bs5 theme here GitHub - https://github.com/angel-vladov/select2-theme-bootstrap5 NPM - https://www.npmjs.com/package/select2-theme-bootstrap5

This is a pre-release version. Please let me know if you find any bugs.