Replace `attr` with `getAttribute` and `setAttribute`

select2 / select2

Select2 is a jQuery based replacement for select boxes. It supports searching, remote data sets, and infinite scrolling of results.

https://select2.org/

MIT License

25.84k stars 6.27k forks source link

Replace `attr` with `getAttribute` and `setAttribute` #6227

Open p8 opened 1 year ago

p8 commented 1 year ago

This pull request includes a

[ ] Bug fix
[ ] New feature
[ ] Translation

The following changes were made

This replaces jQuery's attr function with the vanilla JavaScript getAttribute and setAttribute.

This is related to: https://github.com/select2/select2/issues/6196

kevin-brown commented 1 year ago

Can you rebase this with the latest changes on develop (I merged in your PR to fix the CI, thank you!) and back out the dist changes for me? The dist changes cause annoying merge conflicts across PRs so I prefer to recompile it separately after I merge batches of changes.

p8 commented 1 year ago

@kevin-brown Thanks! Sure will do.

p8 commented 1 year ago

@kevin-brown I've rebased and removed the dist changes.