selectel / pyte

Simple VTXXX-compatible linux terminal emulator
http://pyte.readthedocs.org/
GNU Lesser General Public License v3.0
649 stars 101 forks source link

Fix example `capture.py` #171

Closed hartwork closed 8 months ago

hartwork commented 9 months ago

Hi, thanks for examples/capture.py! :pray:

While playing with it I discovered three key issues about it and felt like offering a pull request with fixes to give back. These issues were:

As a bonus I resolved a needless else to reduce nesting and make the structure a bit simpler. Review on commit level is probably most efficient.

What do you think?

hartwork commented 8 months ago

@selectel I believe this is ready for merge now. What do you think?

hartwork commented 8 months ago

@selectel I believe this is ready for merge now. What do you think?

superbobry commented 8 months ago

Thanks, Sebastian.

@selectel does not maintain this repo, sadly. It's just me checking in once in a while.

hartwork commented 8 months ago

@superbobry thanks for the merge! Has it been considered to move/transfer the repository to your account?

superbobry commented 8 months ago

I very much want @selectel to relicense pyte under a more permissive license first, and then transfer to another org/account.

Ping @tnt-dev :)