search

selective-inference / R-software

R software for selective inference
GNU General Public License v2.0
34 stars 18 forks source link

Added debiased lasso for linear regression when type='full' and n < p #24

Closed kevinbfry closed 7 years ago

jonathan-taylor commented 7 years ago

Tried running my numerical comparisons of R and python code in this branch, had a few R errors:

object 'Ccoxmart' not found

?

kevinbfry commented 7 years ago

Huh, weird.

A quick google search shows that this is a problem people have found with the 'survival' package when they upgraded R from 3.3.3 to 3.4.0. I am currently using R 3.3.3 which explains why I am not having trouble, maybe because you are on a newer version of R you are having an issue?

This link suggests that you need to reinstall the 'survival' package.

jonathan-taylor commented 7 years ago

Nevermind -- this is because my environment did not have R's survival. Comparison with R still the same.

tibshirani commented 7 years ago

Jon

i now have to take care of some pull requests

Have never done this. Could you summarize what I need to do in a few lines?

thanks

On Tue, Aug 8, 2017 at 5:39 PM, Jonathan Taylor notifications@github.com wrote:

Nevermind -- this is because my environment did not have R's survival. Comparison with R still the same.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/selective-inference/R-software/pull/24#issuecomment-321119855, or mute the thread https://github.com/notifications/unsubscribe-auth/ACt3Yfey8CQWM-SHs-5X15hgSDpybA94ks5sWP_EgaJpZM4OwZgQ .

--

I get so much email that I might not reply to an incoming email, just because it got lost. So don't hesitate to email me again. The probability of a reply should increase.

Prof. Robert Tibshirani Depts of Biomedical Data Sciences, and Statistics Stanford Univ Stanford CA 94305 tibs@stanford.edu http://www-stat.stanford.edu/~tibs

jonathan-taylor commented 7 years ago

For this one -- I fixed the conflict in .travis.yml

You should probably just have to hit "Merge pull request" above. To get this code on your machine you will have to git fetch and git pull -- this will just merge it on github.