search

seleniumbase / SeleniumBase

📊 Python's all-in-one framework for web crawling, scraping, testing, and reporting. Supports pytest. UC Mode provides stealth. Includes many tools.
https://seleniumbase.io
MIT License
4.67k stars 929 forks source link

Inconsistent file permissions for the same file types #1722

Closed mdmintz closed 1 year ago

mdmintz commented 1 year ago

Inconsistent file permissions for the same file types

Eg:

Screenshot 2023-02-01 at 6 51 32 PM

Some 775s, 644s, etc. I probably want 664 for all *.py files.

This might not be considered a real bug, since it didn't seem to have any impact on the tests, but maybe something will improve after making things consistent.

mdmintz commented 1 year ago

This was fixed in 4.12.4 - https://github.com/seleniumbase/SeleniumBase/releases/tag/v4.12.4 - (https://github.com/seleniumbase/SeleniumBase/pull/1731)

mdmintz commented 1 year ago

I noticed that the tar.gz file in https://pypi.org/project/seleniumbase/4.12.4/#files is bigger and now contains the SeleniumBase examples folder. This is a result of the updated permissions. Since .whl files are the ones used for pip installs, this shouldn't increase install times.

mdmintz commented 1 year ago

The fixes continued in 4.12.5 - https://github.com/seleniumbase/SeleniumBase/releases/tag/v4.12.5