search

seleniumhq-community / docker-seleniarm

Multi-Arch (arm64/armhf/amd64) Docker images for the Selenium Grid Server
https://hub.docker.com/u/seleniarm
Other
249 stars 26 forks source link

small addition to readme to confirm graviton compatibility #13

Closed triesztui closed 2 years ago

jamesmortensen commented 2 years ago

Hi @triesztui Thanks for the contribution. I just created an AWS Graviton instance. Do you mind documenting the steps on how to set it up, and I can validate it?

Haven't tried yet, but I assume you're doing something like:

$ docker run --rm -it -p 4444:4444 -p 7900:7900 --shm-size 2g seleniarm/standalone-chromium:latest

and then opening up the necessary ports 4444/7900 through the firewall?

Also, are you doing anything to secure the instance from outside abuse?

Thanks again, James

triesztui commented 2 years ago

Hi @jamesmortensen ,

I actually use an EKS cluster with additional graviton worker node group. Then I used the "official" selenium grid helm chart: https://github.com/SeleniumHQ/docker-selenium/tree/trunk/charts/selenium-grid

and just updated the images to point to yours.

I only tested the hub and firefox ones, as I would like to keep covering the google chrome browser, not the chromium one. (I used taints and node selectors to make sure these containers will run on the graviton workers and nothing else.)

relevant extract from the values

    hub:
      # Selenium Hub image name
      # imageName: selenium/hub
      imageName: seleniarm/hub

...

    firefoxNode:
      # Enable firefox nodes
      enabled: true
      # Number of firefox nodes
      replicas: 3
      # Image of firefox nodes
      # imageName: selenium/node-firefox
      imageName: seleniarm/node-firefox

thank YOU very much for producing these images. I believe the arm use case is important cost and carbon footprint saving opportunity so I do hope the selenium folks will start publishing these images soon as well on the official channel.

jamesmortensen commented 2 years ago

Hi @triesztui do you think it would make sense to also add the above sample configuration (For an arm hub and 3 arm Firefox) to the readme, or do you think it is enough to just mention it works on AWS?

jamesmortensen commented 2 years ago

Hi @triesztui I'll go ahead and merge this. Thank you!

triesztui commented 2 years ago

Hi @triesztui I'll go ahead and merge this. Thank you!

Thank you James. I was thinking the easiest way to include example but I think it would be outside of the scope of this repo to elaborate on a k8s setup here. Maybe a dedicated example repo somewhere else we can just refer to.