seleniumhq-community / docker-seleniarm

Multi-Arch (arm64/armhf/amd64) Docker images for the Selenium Grid Server
https://hub.docker.com/u/seleniarm
Other
248 stars 24 forks source link

Fix race condition when launching websockify. #20

Closed xavierog closed 2 years ago

xavierog commented 2 years ago

Description

Fix for the race condition thoroughly investigated in issue #18 Summary of issue #18: noVNC's launch.sh invokes ps. Without it, it exits prematurely, thus ruining websockify's stdout and stderr file descriptors. Depending on how fast websockify starts up, this may or may not prevent it from working.

Types of changes

Checklist

jamesmortensen commented 2 years ago

From what I can tell, this looks great, but for some reason CircleCI is using pulls/20 as the name of the branch, perhaps because it's a pull request from a forked repository.

To get the CI server to build and test the images, we'll need to replace the VERSION environment variable with something that meets the naming conventions for Docker tags. Docker tags can't have forward slashes.

If you have time, you can make that change yourself, even hard-coding "today" or "now" or "HEAD" for the VERSION environment variable should do the trick, on lines 42 and 102:

https://github.com/xavierog/docker-seleniarm/blob/a8adc841eba0277cfe6c3efa0a82e9d49a722894/.circleci/config.yml#L42

https://github.com/xavierog/docker-seleniarm/blob/a8adc841eba0277cfe6c3efa0a82e9d49a722894/.circleci/config.yml#L102

If you're able to make those changes, then it also would fix https://github.com/seleniumhq-community/docker-seleniarm/issues/21 as well as fix https://github.com/seleniumhq-community/docker-seleniarm/issues/18

jamesmortensen commented 2 years ago

Thank you @xavierog