search

seleniumhq-community / docker-seleniarm

Multi-Arch (arm64/armhf/amd64) Docker images for the Selenium Grid Server
https://hub.docker.com/u/seleniarm
Other
248 stars 24 forks source link

[🐛 Bug]: When branches contain a slash in them, the build process fails since images cannot be tagged with a slash. #21

Closed jamesmortensen closed 2 years ago

jamesmortensen commented 2 years ago

What happened?

In the build process, we use the branch name as the version. If the branch name has a slash in it, such as "pulls/20", then the following error occurs:

error: invalid tag "seleniarm/base:pull/20-today": invalid reference format

We could fix this in the circleci/config.yml file by replacing slashes in the branch name with dashes, or by using the Selenium version number instead of the branch name.

Command used to start Selenium Grid with Docker

Any commits to a branch starts the [Seleniarm CircleCI build and test jobs](https://app.circleci.com/pipelines/github/seleniumhq-community/docker-seleniarm).

Relevant log output

cd ./Base && docker buildx build --platform linux/arm64  -t seleniarm/base:pull/20-today .
[+] Building 0.0s (0/0)                                                         
error: invalid tag "seleniarm/base:pull/20-today": invalid reference format
make: *** [Makefile:146: base_multi] Error 1

Exited with code exit status 2
CircleCI received exit code 2

Operating System

Ubuntu 20.04 arm64

Docker Selenium version (tag)

any Docker tag containing a slash