Added request ID to RouteServlet

seleniumkit / gridrouter

Selenium-based solution to serve 1000+ browsers

Other

152 stars 36 forks source link

Added request ID to RouteServlet #26

Closed vania-pooh closed 8 years ago

qatools-ci commented 8 years ago

SonarQube analysis reported 3 issues:

1 critical
2 major

Watch the comments in this conversation to review them. Note: the following issues could not be reported as comments because they are located on lines that are not displayed in this pull request:

Refactor this code to not nest more than 3 if/for/while/switch/try statements.
Remove this misleading mutable servlet instance fields or make it "static" and/or "final"

vania-pooh commented 8 years ago

btw, the build http://ci.qatools.ru/job/gridrouter_build-war/74/console has passed.

smecsia commented 8 years ago

http://ci.qatools.ru/job/gridrouter_build-war/ru.qatools.seleniumkit$gridrouter-proxy/74/testReport/junit/ru.qatools.gridrouter/StatsServletTest/testEvictionOfOldSession/

vania-pooh commented 8 years ago

@smecsia will take a look tomorrow.

vania-pooh commented 8 years ago

All this stuff with broken tests needs to be investigated independently. These tests are unstable: they always fail on my Mac, but pass on Linux even with my changes. I opt for merging this.