seleniumkit / selenograph

Powered version of Selenium Grid Router
Other
42 stars 14 forks source link

Remove split the browser name by dash "-" #6

Closed Shnitzelil closed 8 years ago

Shnitzelil commented 8 years ago

The class Key contains a method that split the browser name by dash delimiter. this raise limitation when working the browser name like "Android-1". The original Selenium GRID does support this...

public static String browserName(String name) { return name.contains("-") ? name.split("-")[0] : name; }

or provide an escaping on this character

Thanks

smecsia commented 8 years ago

@Shnitzelil please try the newer version 1.1, which we've just released. It can be installed from debian package.

Shnitzelil commented 8 years ago

great!!!

Do I need to do something special?

On Fri, Jul 22, 2016 at 2:34 PM, Ilya notifications@github.com wrote:

@Shnitzelil https://github.com/Shnitzelil please try the newer version 1.1, which we've just released. It can be installed from debian package.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seleniumkit/selenograph/issues/6#issuecomment-234521656, or mute the thread https://github.com/notifications/unsubscribe-auth/AHrq5y39jUgpwfU9Pl8vzN1OxL6PHUldks5qYKq5gaJpZM4JPmSr .

Kobi Gana קובי גנה

vania-pooh commented 8 years ago

@Shnitzelil no, it should just work.

Shnitzelil commented 8 years ago

Hey,

  1. failed on missing property "grid.router.quota.repository"... I added it manually with ru.qatools.gridrouter.ConfigRepositoryXml value
  2. missing used api /api/selenograph/map/HubBrowserState any alternative to resolve the Selenium Hub and/or Selenium Node?

Thanks

On Sun, Jul 24, 2016 at 10:16 AM, Ivan Krutov notifications@github.com wrote:

@Shnitzelil https://github.com/Shnitzelil no, it should just work.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/seleniumkit/selenograph/issues/6#issuecomment-234762225, or mute the thread https://github.com/notifications/unsubscribe-auth/AHrq58QAZeZsV_IFC7o0FPprNxehPLCXks5qYxExgaJpZM4JPmSr .

Kobi Gana קובי גנה