search

self-xdsd / self-core

Self's core, implemented with Java SE 11.
https://self-xdsd.com
Other
28 stars 12 forks source link

The PM doesn't react when the issue is closed #1214

Closed fedorpashin closed 3 years ago

fedorpashin commented 3 years ago

The documentation says:

When the Issue is closed or PR is merged, the PM will add it to the Contributor’s active Invoice.

But when I closed this issue nothing happened. Even after I linked the issue in a PR and close it while merging, the PM stubbornly doesn't react to this)

zoeself commented 3 years ago

@fedorpashin thank you for reporting this. I'll assign someone to take care of it soon.

zoeself commented 3 years ago

@amihaiemil I couldn't find any assignee for this task. This is either because there are no contributors with role DEV available or because the project does not have enough funds.

Please, make sure there is at least one available contributor with the required role and the project can afford to pay them.

amihaiemil commented 3 years ago

@fedorpashin The PM checks the closed Issues every 30 minutes. It doesn't react automatically when an Issue is closed because many people usually close issues by mistake (they click "Close with comment").

So, it should reply within 30 minutes (maximum) after an Issue is closed.

Also, linking PRs and Issues has no effect :D

amihaiemil commented 3 years ago

@fedorpashin I looked in the logs and there is indeed a problem with fedorpashin/statistical-modeling: Github returns status 410 GONE, for one of the Issues. Strange. Let me check further.

amihaiemil commented 3 years ago

@fedorpashin I think the problem should be fixed now :D

amihaiemil commented 3 years ago

@fedorpashin problem was that Issue number 2 from that Repo has been deleted from Github (didn't even know that was possible, sorry :D ) and Self doesn't handle that case. I'll open an Issue for it.

fedorpashin commented 3 years ago

Also, linking PRs and Issues has no effect :D

I reverted the PR, because I thought that was the problem 😄

BTW, it would be convenient, I think, if the PM somehow understood what are the related issues and linked them automatically. For example, if comment contains "PR for #...".

fedorpashin commented 3 years ago

@fedorpashin problem was that Issue number 2 from that Repo has been deleted from Github (didn't even know that was possible, sorry :D ) and Self doesn't handle that case. I'll open an Issue for it.

Wow, okay)

amihaiemil commented 3 years ago

@fedorpashin

BTW, it would be convenient, I think, if the PM somehow understood what are the related issues and linked them automatically

Maybe, but the moment I see no usecase for this :D Each Issue or PR is treated as a separate task (Issue is for DEV role, PR is for REV role, that's it).