search

selfconference / selfconf-android

Android app for Self.conference
https://play.google.com/store/apps/details?id=org.selfconference.android
0 stars 0 forks source link

2019 Dependencies/Libraries Update #30

Closed matteatsleftovers closed 5 years ago

matteatsleftovers commented 5 years ago

What does this PR do❓

This PR updates the dependencies and libraries of the self.conference Android app to be compatible with 2019 tooling. In particular, the following are library upgrades that were recommended by the library developers:

Before the changes made in this PR, I could not build the project in the latest Android Studio. The first commit (19e4085) in this PR fixes that. This PR addresses Android Studio/build tools incompatibility, deprecation warnings, and a few other minor warnings. The app now has minimum SDK 21 (Lollipop) to take advantage of the newest tools and dependencies. Very likely that self.conference attendees with Android phones will be on Lollipop or later.

Finally, this PR updates the conference dates to those of self.conference 2019, allowing users to actually see the sessions for June 7 and June 8!

How to test it 🔬

  1. Clone the code in the 2019-update branch.
  2. Build the code with the latest version of Android Studio (3.4.1 for macOS as of this writing). You should face no build errors and only a few warnings.
  3. Run the app on an emulator or an Android device (Lollipop and higher). You should see sessions, speakers, and sponsors for the 2019 conference, and be able to "submit feedback". The app is behaviorally the same as previous years (hence version 2.0.10), so expect it to function the same!

Any background info you would like to include ✅

Hi! 👋 This is my first PR to the selfconf-android project. My name's Matt, an Android/Java developer at Detroit Labs. Macklin and Amber set up this project really nicely, and I just wanted to get it into ship shape for 2019. 🚢

Screenshots (if applicable) 📷

selfconf-android-2019-preview

Acknowledgements

Special thanks to @BritneyS for the PR template!

rstockbridge commented 5 years ago

I'm getting the build error described here: https://stackoverflow.com/questions/55214993/error-no-signature-of-method-com-crashlytics-tools-gradle-crashlyticsplugin-fi

Did you run into this at all?

matteatsleftovers commented 5 years ago

I'm getting the build error described here: https://stackoverflow.com/questions/55214993/error-no-signature-of-method-com-crashlytics-tools-gradle-crashlyticsplugin-fi

Did you run into this at all?

Oh dear! I did not run into that, but I haven't built the app in a week. 😅 Let me investigate and push any needed changes.

matteatsleftovers commented 5 years ago

@rstockbridge, I add the simplest possible error handling for sponsors with no image and no link in the latest commit. Picasso, surprisingly, prefers null to empty strings for empty images!

GIF attached showing more graceful sponsor handling. Re-requesting your review. 🙏

empty-sponsor-crash-fix

rstockbridge commented 5 years ago

Strange about null vs empty string! Change looks great, thanks for the fix!