selfcustody / krux-installer

A GUI based application to flash Krux firmware on K210 based devices (WIP)
MIT License
6 stars 6 forks source link

v0.0.2-alpha #66

Closed qlrd closed 3 weeks ago

qlrd commented 4 weeks ago

Description

Electron deprecated, long live kivy! Major update to python code base:

What is the purpose of this pull request?

codecov[bot] commented 4 weeks ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

qlrd commented 3 weeks ago

I am genuinely impressed with how quickly you accomplished the task of translating the entire application from one language/platform to another. Not only that, but you've also implemented numerous improvements along the way. You managed the added complexity of ensuring compatibility with various OS species and subspecies, as well as handling translations, with great skill.

I cant did that withou the team. You, @tadeubas and @jdlcdl helped a lot!

While I initially thought that some areas could be simplified using a more "Pythonic" approach, I now see the value in the setters and getters you incorporated from JavaScript. These likely contributed to the stability of this complex project.

At first time, i didnt like it to. But since i remove any .kv file and go to dynamic GUI, it was needed to coverage them. With more time i will try to make them more readable and clear.

I think we could move one, maybe do a draft release, and you could invite some people in Telegram to test first?

I just made the fix with NotoSans fonts. I will do a final test on OS and wait for @tadeubas /@jdcdl review/approval to tag it and do a release.

Congratulations on a job well done, GUI!

<3

jdlcdl commented 3 weeks ago

This is an enormous project, and this particular pr showing the evolution from one base to another is epic.

I don't have a formal education in programming, but if I did, I'd expect this code-base and its evolution to be a text-book example on how-to attack and maintain a long-lived project. This project and the process of how it has evolved touches on many important aspects of development, treating each one in a clean manner, without cutting corners, and done so with a mission-critical degree of care. As a reference for good practices, I'll refer back to this project in the future.

Beyond the implementation that krux-installer has become, it's most important benefit is to the users, who will be able to install Krux in a safe manner learning all the while. It makes the critically important process of safely installing software simple and clear, and it's a pleasurable experience from start to finish.

qlrd commented 3 weeks ago

I don't have a formal education in programming

This really a surprise.

This project and the process of how it has evolved touches on many important aspects of development, treating each one in a clean manner, without cutting corners, and done so with a mission-critical degree of care.

Thanks for kind words, it can't be achieved without you, @odudex and @tadeubas in which took some of your firmware time to pay attention to the installer. Also, I repeatedly needed to see the firmware code (especially the tests), from which I learned a lot. The krux code, PRs and issues are a whole formal course.

it's most important benefit is to the users, who will be able to install Krux in a safe manner learning all the while.

May this be eternal while it lasts!