search

selfcustody / krux

Open-source signing device firmware for Bitcoin
https://selfcustody.github.io/krux/
Other
179 stars 36 forks source link

QR code compatibilty #21

Closed bavarianledger closed 3 years ago

bavarianledger commented 3 years ago

Are the QR codes supposed to be compatible with SeedSigner? I did a couple of tests and I was not able to scan any SeedSigner generated QR code, this error message came up: Invalid mnemonic length

ghost commented 3 years ago

Currently, for loading a mnemonic via QR code, only two formats are supported: 1) A single text string mnemonic like so: "happy boss wall mimic inhale tag pave radio melody text tobacco add", or 2) The 'crypto-bip39' UR type defined here: https://github.com/BlockchainCommons/Research/blob/master/papers/bcr-2020-006-urtypes.md

The first option is what Krux displays and prints out, by the way.

So, if SeedSigner doesn't generate a QR code from one of those two formats, then it wouldn't be supported. If it's simple enough, I suppose I could add support for it, though. Do you know what format they use?

If you want to use a tool to generate the QR code manually from the mnemonic to test with, you could use this: https://iancoleman.io/bip39/ Once you enter the mnemonic, you can click in the text field to have it display the QR code.

bavarianledger commented 3 years ago

SeedSigner is using these formats: https://github.com/SeedSigner/seedsigner/blob/main/docs/qr_formats.md

It seems that the SeedSigner QR format is a text string containing the IDs of the words like: "1166072714130831...".

ghost commented 3 years ago

@bavarianledger Can you pull down the latest and give that a try?

bavarianledger commented 3 years ago

@jreesun Perfect. It's working - the SeedSigner Seed QR codes are now compatible with with Krux and SeedSigner! Thank you!