search

selfcustody / krux

Open-source signing device firmware for Bitcoin
https://selfcustody.github.io/krux/
Other
179 stars 36 forks source link

Remove Logging functionality #268

Closed tadeubas closed 7 months ago

tadeubas commented 1 year ago

Log (INFO, DEBUG, ERROR) is something for the developer and not for the end user. As a programmer, I have never used the functionality.

There are other easier ways to debug and many features don't have any logs (which would have to be created).

When a user reported a problem, shared a photo or video or described the problem, we never requested log files (I do not consider requesting a file from the user to be an appropriate approach when dealing with an HW).

We have a memory problem in the code, we cannot have much loaded, especially code that is not used.

I vote to remove this unused functionality - https://selfcustody.github.io/krux/getting-started/settings/#logging

odudex commented 1 year ago

I agree. We could remove and clean it up.

tadeubas commented 7 months ago

Done in release 24.03.0