Directories suffixed with "/" in file_manager

[jdlcdl]

Description

Suffixes directory names with "/" (display only) in the file_manager (also for the special "../" entry)

What is the purpose of this pull request?

• [ ] Bug fix
• [ ] New Feature
• [ ] Documentation update
• [X] Other

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.66%. Comparing base (5c42590) to head (8bd8cbe).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## develop #421 +/- ## =========================================== + Coverage 94.63% 94.66% +0.02% =========================================== Files 57 57 Lines 7078 7079 +1 =========================================== + Hits 6698 6701 +3 + Misses 380 378 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[odudex]

looks good to me!

[jdlcdl]

I setup to test as of 7be968a via the simulator, w/:

• subdir_1 having 1 file, 1 subdir, 1 soft link, and 1 broken soft link,
• and did the same for subdir_10 and subdir_100 having 10 and 100 of each respectively. Performance was great in the simulator, however broken links were visible leading me to believe that I should NOT assume that simply checking file_exists() was enough, I needed to check dir_exists() as well.

But as I tested the sipeed amigo, I realized that links (working, soft, broken) were not even supported on an sdcard formatted for krux. Further, checking for existence of files and directories was drastically slower on the device than in the simulator. The subdir with 100 files and 100 subdir's was taking around 2.7s. I tried checking only for existence of files and if not assuming directory, as well as for existence of directory and if not assuming file... and performance was exactly the same. 100 files and 100 directories per subdir takes 1.6s in the latest commit above.

[tadeubas]

Have you tested with a loooong folder name? I think it will remove the forward slash, you need to change the code below when filename doesn't fit on the screen, you need to change to use display_filename so the forward slash is taken into account

[jdlcdl]

The 2 last commits are:

• a bug fix for long filenames, which was incomplete (shame on me)
• the bug fix to the above bug fix w/ tests that hopefully cover sorting of dirs before files as well as long filenames.

[odudex]

Thank you!