codecov[bot]
commented
1 month ago Codecov Report
Attention: Patch coverage is 94.30894% with 7 lines in your changes missing coverage. Please review.
Project coverage is 94.31%. Comparing base (
d2ab267) to head (200dffb).
| Files | Patch % | Lines |
|---|---|---|
| src/krux/camera.py | 16.66% | 5 Missing :warning: |
| src/krux/pages/qr_capture.py | 97.80% | 2 Missing :warning: |
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #428 +/- ## =========================================== - Coverage 94.72% 94.31% -0.41% =========================================== Files 57 58 +1 Lines 7127 7146 +19 =========================================== - Hits 6751 6740 -11 - Misses 376 406 +30 ```:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
While UR QR codes employ a complex approach where a progress bar is suitable, BBQr and PMofN require the capture of all their frames. To improve understanding of the capture progress, I'm experimenting with an alternative to the simple, continuous progress bar, where it is possible to visualize captured and missing frames, as well as the last captured one, which helps to determine what frame the wallet is currently showing.
What is the purpose of this pull request?