selfcustody / krux

Open-source signing device firmware for Bitcoin
https://selfcustody.github.io/krux/
Other
185 stars 37 forks source link

Uses grid_type to label TinySeed page ui #436

Closed jdlcdl closed 3 months ago

jdlcdl commented 3 months ago

Description

With my jaw-on-the-floor, while reviewing @3rdIteration's TinySeed improvements to support OneKey-KeyTag and Binary-grid formats, I noticed that once a grid is scanned and user has a chance to edit, that "Tiny Seed" as the title of the page might be confusing (even though krux is not confused about which grid_format to use).

This pr alters TinyScanner's binary_grid_settings for the default key from "TinySeed" to "Tiny Seed" and then passes the grid_type into TinySeed page so that ui/ux labelling can be appropriate for the current mode when editing. note: Only the "Binary Grid" key is localized, while the other two keys retain their trademark english names.

What is the purpose of this pull request?

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.71%. Comparing base (4f18fbe) to head (ed4b4d6).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #436 +/- ## ======================================== Coverage 94.71% 94.71% ======================================== Files 57 57 Lines 7116 7120 +4 ======================================== + Hits 6740 6744 +4 Misses 376 376 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

odudex commented 3 months ago

Thank you!