selfcustody / krux

Open-source signing device firmware for Bitcoin
https://selfcustody.github.io/krux/
Other
175 stars 34 forks source link

adjusted test to cover bugfix in commit 3eba4e4 #437

Closed jdlcdl closed 1 month ago

jdlcdl commented 1 month ago

Prior to commit 3eba4e4 and related to signing messages, if a message contained a ":" colon character, it was converted to a " " space character. This pr adjusts the existing unit-test so that it would fail with prior versions and succeeds with 3eba4e4's fix.

User's who need to sign on a message using a previous release of krux might note the conversion of ":" to " ", which is visible in-device while signing. (ie: In Sparrow's "Sign/Verify Message" screen, they'd convert any ":" characters in the "message" text-area to " "... and then the krux signature would verify as valid)

Description

What is the purpose of this pull request?

odudex commented 1 month ago

Thank you Jean!