selfcustody / krux

Open-source signing device firmware for Bitcoin
https://selfcustody.github.io/krux/
Other
175 stars 34 forks source link

update docs for installing-from-gui section #450

Closed qlrd closed 3 weeks ago

qlrd commented 4 weeks ago

Description

This PR just update the "Installing from GUI" section:

What is the purpose of this pull request?

codecov[bot] commented 4 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.21%. Comparing base (1b03495) to head (569bd12). Report is 3 commits behind head on develop.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #450 +/- ## ======================================== Coverage 94.21% 94.21% ======================================== Files 59 59 Lines 7259 7259 ======================================== Hits 6839 6839 Misses 420 420 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

odudex commented 3 weeks ago

Exemplary documentation! There are minor issues. 2 broken links, listed in mkdocs debug INFO (one left by me!) On /snippets/verify-the-signature-trust-tip.en.txt should #verify-its-authenticity become #verify-the-authenticity? Could you please fix mine to? On /getting-started/usage/navigating-the-main-menu.en.md . [More about wallet attributes](./loading-a-mnemonic.md/#attributes) becomes [More about wallet attributes](./loading-a-mnemonic.md/#confirm-wallet-attributes)

qlrd commented 3 weeks ago

On /snippets/verify-the-signature-trust-tip.en.txt should #verify-its-authenticity become #verify-the-authenticity? Could you please fix mine to? On /getting-started/usage/navigating-the-main-menu.en.md . [More about wallet attributes](./loading-a-mnemonic.md/#attributes) becomes [More about wallet attributes](./loading-a-mnemonic.md/#confirm-wallet-attributes)

Fixed both (i think)

odudex commented 3 weeks ago

Thank you!