search

selfdefined / web-app

Dictionary database with future API and bot integrations
https://www.selfdefined.app/
573 stars 172 forks source link

Rename "colourblind" definition file #373

Closed ashur closed 3 years ago

ashur commented 3 years ago

Description

Currently, the link from the main page to the colourblind article is broken. On closer inspection, the definition filename uses the color spelling variation, while the slug uses colour.

Changes

This PR makes one change:

Notes

The definition file's frontmatter uses the u variation of colour twice:

title: colourblind
slug: colourblind

leading me to believe that is the intended spelling. Rather than change those values to match the file name, I renamed the file to match the frontmatter.

Personal Notes

I'm very sorry if this is the wrong way to go about fixing a broken link in this case where I'm not 100% positive about the best path forward! I didn't see anything related in the contributing guidelines, but if it would be more appropriate to open an issue I'm more than happy to do that.

Thanks!

tatianamac commented 3 years ago

This is perfect. Thank you for catching that error and opening up a PR, @ashur! I'll open an issue to make renaming files more clear (I also owe a "style guide" type post to the docs to clarify that we use International English. 🙃)