selfdefined / web-app

Dictionary database with future API and bot integrations
https://www.selfdefined.app/
573 stars 172 forks source link

Update to node 14, update dependencies #404

Closed mpcsh closed 3 years ago

mpcsh commented 3 years ago

I've been noticing some npm warnings; this PR addresses them.

Things that'd be nice to do:

tatianamac commented 3 years ago

@mpcsh This looks awesome!

For the two "nice to haves", they sound good to me. What would you need from me to add these to this PR (or would you want to add these to this PR?)

mpcsh commented 3 years ago

I think the two nice-to-haves should probably be their own PRs. for npm outdated, major semver upgrades can introduce breaking changes, so we should probably open up a new branch and introduce them one at a time. for those CSS warnings, I think I'd need to pair on them. will DM 😁

ovlb commented 3 years ago

@mpcsh Could you also update the .nvmrc file in a future PR?

mpcsh commented 3 years ago

Oh, I think we should probably remove it for the same reason as with this file (i.e., we shouldn't commit tool versioning configs, that should be up to folks to manage as they see fit)